This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Fix deprecated swiftmailer parameter #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 30, 2016
|
Thank you @piotrantosik. |
fabpot
added a commit
that referenced
this pull request
Dec 31, 2016
| @@ -12,7 +12,7 @@ | |||
| "doctrine/orm": "^2.4.8", | |||
| "doctrine/doctrine-bundle": "~1.4", | |||
| "symfony/assetic-bundle": "~2.3", | |||
| "symfony/swiftmailer-bundle": "~2.3", | |||
| "symfony/swiftmailer-bundle": "~2.3,>=2.3.10", | |||
There was a problem hiding this comment.
Why not just ~2.3.10?
There was a problem hiding this comment.
~2.3.10 would forbid to install 2.4.0, for example, once it got released.
There was a problem hiding this comment.
@xabbuh Ah, it makes sense. But ^2.3.10 would allow 2.4.0, right?
There was a problem hiding this comment.
@xabbuh Thanks and happy New Year! :)
There was a problem hiding this comment.
@bocharsky-bw Happy new year for you too! :)
There was a problem hiding this comment.
Yep I also recommend ^2.3.10 which is nicer :)
There was a problem hiding this comment.
done in more recent versions of SE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed pr #1037 @xabbuh please review